TfrxPreview AccessViolation by using Find Function

leoni

Hi,

When you put the TfrxPreview into a vcl container component like a TPanel, some of the Find Functions give you AccessViolations.

A simple test is to put a TfrxPreview onto a TPanel, show the report in runtime, and then call the frxPreview1.Find Method.
Another simple test is to set the frxPreview1.FindFmVisible Property true, and then click in runtime the Find Button in the right shown Element.

I suggest the problem is FastReport referencing the FindForm in a few places in code via eg TfrxPreviewForm(Self.Parent).FindB.Down := False;
This not account the situation the TfrxPreview itself is embedded in a ContainerElement and not in the form itself where I suggest the TfrxPreviewform do its own create.

best regards
Markus

gpi

Modify frxPreview.pas

@@ -2152,6 +2152,11 @@ begin
     end;
     Free;
   end;}
+  if not (Self.Parent is TfrxPreviewForm) then
+    begin
+      FindFmVisible := not FindFmVisible;
+      exit;
+    end; 
 
   if not TfrxPreviewForm(Self.Parent).FindB.Down then
      TfrxPreviewForm(Self.Parent).FindB.Down := True
@@ -2588,7 +2593,8 @@ begin
     end
     else
       FWorkSpace.FLastFoundPage := PageNo - 1;
-    TfrxPreviewForm(Self.Parent).FindB.Down := False;
+    if Self.Parent is TfrxPreviewForm then
+      TfrxPreviewForm(Self.Parent).FindB.Down := False;
     FindFmVisible := False;
     Self.SetFocus;
   end;